OSX: Close App When All Windows Closed #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Closes the app when the renderer process is stopped when using on OSX, so menu item errors cannot be thrown.
Reason:
What lead me to this PR, was that the menu items will throw errors when the renderer is closed. This update makes sure the main process is killed with the renderer process, so this cannot happen.
The main process menu items requires the webContents object to be present, and without a tray menu, I'm not seeing a reason for the app to stay open after the main renderer process closes in OSX. Maybe I'm overlooking something?