Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving @types dependencies to devDependencies #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barakshechter
Copy link

@barakshechter barakshechter commented Dec 3, 2019

Moving the type dependencies to devDependencies since the compiled index.js has no direct need for them. The only hard dependency this library needs is cls-hooked.

@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 74da837 on barakshechter:move-type-deps-to-dev-only into f6b63dc on skonves:master.

@barakshechter
Copy link
Author

Hi @skonves ,

I was depending on your library when I noticed it had a hard dependency on express types, which theoretically only apply when developing in typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants