[ENH] Test Parameters for FinancialHolidaysTransformer
#6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharma-kshitij-ks
requested review from
achieveordie,
benHeid,
fkiraly and
yarnabrina
as code owners
fkiraly
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks!
For explanation, parameter_set is not used in transformations and should not be used, it is just there for higher-level interface unification. It is also crucial that get_test_params never raises a ValueError.
Could you be so kind to not modify the docstring, or the return type, or the behaviour of the interface?
Simply return a list of dicts, that would be great.
fkiraly
added
module:transformations
sharma-kshitij-ks
force-pushed
the
checks
branch
from
10e5535
to
fa404b9
Compare
Added supported "ECB" market as a test parameter.
|
Looks Good! I'm getting the output "All tests PASSED!" when running check_estimator locally. @fkiraly
|
fkiraly
changed the title
FinancialHolidaysTransformer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've another supported test parameter set that covers substantially different setting as compared to the default parameters.
Here are the two distinct valid parameter sets:
Parameter Set 1 (Default):
Market: "XNYS" - New York Stock Exchange
Parameter Set 2:
Market: "ECB" - European Central Bank