Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates
joblib
, turning it from a de-facto direct dependency in a soft dependency that happens to be an indirect core dependency.Currently:
joblib
is an indirect core dependency, as core dependency of core dependencyscikit-learn
.joblib
at module levelTherefore, if
scikit-learn
were to dropjoblib
as a dependency,sktime
would break - as a package.For this reason, it is best practice to have direct imports as a direct core dependency, which is done in #6384.
However, the
joblib
dependencies are entirely optional, as not coupled to the framework, only to specific estimators (mostly/morally). So we can turn it into a silent soft dependency, which is the approach taken by this PR.Some exceptions concern the tests, but in all such cases there are existing isolations in
scikit-base
which can be followed, pending de-duplication of test code.