Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] replace proba module by skpro - diagnostic to ensure API consistency #6393

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[MNT] replace proba module by skpro - diagnostic to ensure API consistency #6393

wants to merge 11 commits into from
+19 −2,054

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented May 6, 2024

DO NOT MERGE

This PR carries out a naive replacement of sktime's proba module by skpro (distributions), current main which has the unreleased upgrade of probability distribution objects.

The purpose is to check that the public API remains unchanged, regarding the parts required by sktime.

@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:probability&simulation probability distributions and simulators do not merge should not be merged - e.g., CI diagnostic, experimental labels May 6, 2024
@fkiraly fkiraly changed the title [MNT] replace proba module by skpro [MNT] replace proba module by skpro - diagnostic to ensure API consistency May 6, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented May 6, 2024

FYI @Alex-JG3, @frthjf, @malikrafsan, @ShreeshaM07, @yarnabrina

@fkiraly
Copy link
Collaborator Author

fkiraly commented May 7, 2024

takeaways:

  • interface-wise, direct replace is possible without problems from current skpro main
  • minor issues where sktime checks inheritance from BaseObject - this needs to be changed from sktime BaseObject to skbase BaseObject, as these are distinct classes

@fkiraly fkiraly mentioned this pull request May 7, 2024
Open
@frthjf
Copy link

frthjf commented May 7, 2024

Neat! Is the plan to release this in the future or will skpro remain an optional dependency in sktime?

@frthjf
Copy link

frthjf commented May 7, 2024

Sorry, just saw that you've already discussed this in #6396. Will comment over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie will be requested when the pull request is marked ready for review achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid will be requested when the pull request is marked ready for review benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina will be requested when the pull request is marked ready for review yarnabrina is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge should not be merged - e.g., CI diagnostic, experimental maintenance Continuous integration, unit testing & package distribution module:probability&simulation probability distributions and simulators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fkiraly @frthjf