Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] maintenance changes for AutoTBATS #6400

Merged
merged 4 commits into from May 10, 2024

Conversation

yarnabrina
Copy link
Collaborator

@yarnabrina yarnabrina commented May 9, 2024

This PR adds some minor enhancements in StatsForecastAutoTBATS:

  1. supports new arguments added in newer statsforecast to control box cox parameter range for automated selection
  2. updates existing test parameters with use of more arguments for higher coverage
  3. removes internal use of deprecated seasonal_periods parameter instead of consistent season_length parameter -> this is not a breaking change as user interface is unchanged

@yarnabrina yarnabrina added the module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting label May 9, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented May 9, 2024

could you write a PR description?

@yarnabrina
Copy link
Collaborator Author

could you write a PR description?

I so wish that Github becomes smart enough to create descirption from commit messages automatically. Added now.


Notes for reviewers:

  1. I've modified the code internally so that we do not use a deprecated parameter. However I kept the user interface same to avoid deprecation. Is that okay or should I change there as well?
  2. This parameter also happens to be a positional parameter in statsforecast, not positional only though. Should we consider setting a default value (1 seems generic and consistent with other estimators), or should we keep it as it is?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for explaining

@yarnabrina yarnabrina merged commit e383fed into sktime:main May 10, 2024
54 checks passed
@yarnabrina yarnabrina deleted the statsforecast-maintenance branch May 10, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:forecasting forecasting module: forecasting, incl probabilistic and hierarchical forecasting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants