Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] remove redundant/duplicative classification tutorial notebooks #6401

Merged
merged 1 commit into from May 22, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented May 9, 2024

This PR removes three of the "minor" classification notebooks, they were very short and formulaic, fitting a single classifier.

There is no additional content, compared to the basic classification vignette and the tuning vignette, imo, except for the choice of a different classifier.

The classifiers in the notebook are also costly to run as part of the tests, so I see strong reasons to simply remove these notebooks.

@fkiraly fkiraly added documentation Documentation & tutorials module:classification classification module: time series classification labels May 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fkiraly fkiraly merged commit 0cd5a32 into main May 22, 2024
17 checks passed
@fkiraly fkiraly deleted the remove-classif-nb branch May 22, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials module:classification classification module: time series classification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant