Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's possible to get negative timestamp differences in skulpt
But all timestamps should really be monotonically increasing
(unless the system time was changed between calls)
This pr fixes that with an implementation that entirely depends on the browser
performance
api.(falling back to the
Date.now()
api if theperformance
api is not available)The previous implementation combined the two apis which led to negative timings since the fractional offset was not accurate with respect to
Date.now()
.I've added comments for browser compatibility links to mdn.
I haven't added additional tests since node doesn't support
performance
without arequire('perf_hooks')
.I also replace
this
withSk.global
in a few places which I think is safer.