Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1013: Add Packit integration to GitHub project for Fedora CI #1014

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Contributor

@jiridanek jiridanek commented Mar 24, 2023

Copr build status

Regarding builds in Packit (COPR), currently only aarch64 and x86_64 are passing. The s390x and ppc64le are failing on unrecognized command-line option '-mno-omit-leaf-frame-pointer' which is from #1074

@kgiusti will be surely gladdened to see that libunwind seems to be available on all the architectures, there are no failures building the src.rpm caused by its absence.

https://copr.fedorainfracloud.org/coprs/jdanek/skupper-router/build/6017943/

@jiridanek jiridanek changed the title Draft: Packit integration Draft: Fixes #1013: Add Packit integration to GitHub project for Fedora CI Mar 24, 2023
@jiridanek jiridanek linked an issue Mar 24, 2023 that may be closed by this pull request
@jiridanek
Copy link
Contributor Author

jiridanek commented Mar 24, 2023

@ganeshmurthy @kgiusti "Look, folks, so many CI jobs!"

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1014 (dcc55e9) into main (7c658af) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1014     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files        247     247             
  Lines      63991   63897     -94     
  Branches    5896    5873     -23     
=======================================
- Hits       49775   49697     -78     
+ Misses     11532   11524      -8     
+ Partials    2684    2676      -8     
Flag Coverage Δ
pysystemtests 87.7% <ø> (-0.1%) ⬇️
pyunittests 54.6% <ø> (ø)
systemtests 71.3% <ø> (-0.1%) ⬇️
unittests 21.9% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
unittests 26.0% <ø> (+<0.1%) ⬆️
systemtests 78.4% <ø> (-0.1%) ⬇️

@jiridanek
Copy link
Contributor Author

jiridanek commented Mar 24, 2023

@jiridanek
Copy link
Contributor Author

$ python3 -c 'import packaging.version; print(packaging.version.parse("0.0.git.3973.71ba5332"))'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/jdanek/.local/lib/python3.11/site-packages/packaging/version.py", line 52, in parse
    return Version(version)
           ^^^^^^^^^^^^^^^^
  File "/home/jdanek/.local/lib/python3.11/site-packages/packaging/version.py", line 197, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '0.0.git.3973.71ba5332'

@jiridanek jiridanek marked this pull request as ready for review April 1, 2023 20:55
@jiridanek jiridanek changed the title Draft: Fixes #1013: Add Packit integration to GitHub project for Fedora CI Fixes #1013: Add Packit integration to GitHub project for Fedora CI Apr 1, 2023
@jiridanek
Copy link
Contributor Author

That rpm-build:fedora-rawhide-s390x is just a flake, due to #959

@jiridanek
Copy link
Contributor Author

I finally received Testing Farm API key (https://docs.testing-farm.io/general/0.1/onboarding.html). So that means we (anyone I share the key with) can also trigger the Testing Farm tests from their own machine, without going through the GH PR. Currently the Testing Farm only installs the RPMs.

Here is your API key: https://xxx

(note the link is accessible only once).

Documentation:

    https://docs.testing-farm.io/

We have an CLI tool available for easy interaction with the API:

    https://docs.testing-farm.io/general/0.1/cli.html

The main input format for our service is `tmt`:

    https://tmt.readthedocs.io/en/stable/guide.html

The list of possible composes to test against is:

    https://docs.testing-farm.io/general/0.1/test-environment.html#_composes

List of supported architectures:

    https://docs.testing-farm.io/general/0.1/test-environment.html#_supported_architectures

Please let us know if you have any questions.

You can find us on #testing-farm Red Hat Slack.

@jiridanek
Copy link
Contributor Author

https://copr.fedorainfracloud.org/coprs/jdanek/skupper-router/build/6086829/

Epel 8 fails on Python dependency, that is to be ignored. There is a segfault in rawhide arm64 test for symbolized backtrace. Then system_tests_tcp_adaptor_tls fails on s390x with AssertionError: openssl s_client failed with returncode 1 b'depth=1 CN = Trusted.CA.com, O = Trust Me Inc.\nverify return:1\ndepth=0 CN = localhost, O = Server\nverify return:1\n000003FFB8C77C00:error:0A000126:SSL routines:ssl3_read_n:unexpected eof while reading:ssl/record/rec_layer_s3.c:321:\n'

I could enable running more tests (subsequent PR), and I guess more arches can be enabled now, besides aarch64, since the compilation failure is now fixed (either subsequent PR, or maybe right here).

@@ -21,18 +21,51 @@ under the License

== rpm

The `rpkg` tool expects to have a `spec.rpkg` file at the source root.
In order to build, first link the spec file to the expected location.
The `packit` tool edits the `packaging/skupper-router.srpm` file.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `packit` tool edits the `packaging/skupper-router.srpm` file.
The `packit` tool edits the `packaging/skupper-router.spec` file.

@jiridanek
Copy link
Contributor Author

Note to self: this got stuck on the arm64 crash when libunwind is present

@jiridanek jiridanek marked this pull request as draft January 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use packit for upstream RPMs
1 participant