Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bollard requirement from 0.15 to 0.16 #1434

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Updates the requirements on bollard to permit the latest version.

Release notes

Sourced from bollard's releases.

Release v0.16.0

What's Changed

New Contributors

Full Changelog: fussybeaver/bollard@v0.15.0...v0.16.0

What's Changed

New Contributors

... (truncated)

Commits
  • 907fcf6 Merge pull request #378 from fussybeaver/ND/release-0.16
  • 446730f build: Release 0.16
  • 6c50594 feat: Bump the default API version to 1.44
  • f9a6b3d docs: Update README to 0.16 release
  • edf7131 build(circleci): Bump docker circleci image
  • 2f14024 Merge pull request #377 from fussybeaver/ND/proto-0.3.0
  • 8ab6702 docs: Update grpc docs (remove TODO)
  • c349ca8 chore(deps): Bump tonic / tonic-build
  • e173114 build: Bump versions to match internal deps
  • cc08bca build: Update buildkit source to match proto files
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [bollard](https://github.com/fussybeaver/bollard) to permit the latest version.
- [Release notes](https://github.com/fussybeaver/bollard/releases)
- [Commits](fussybeaver/bollard@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: bollard
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #1434 (b2dc24e) into main (9fb393b) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1434   +/-   ##
=====================================
  Coverage   77.4%   77.4%           
=====================================
  Files        246     246           
  Lines      63991   63992    +1     
  Branches    5912    5912           
=====================================
+ Hits       49539   49570   +31     
+ Misses     11729   11706   -23     
+ Partials    2723    2716    -7     
Flag Coverage Δ
pysystemtests 87.6% <ø> (+<0.1%) ⬆️
pyunittests 54.5% <ø> (ø)
systemtests 70.9% <ø> (+<0.1%) ⬆️
unittests 21.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
unittests 25.9% <ø> (ø)
systemtests 78.1% <ø> (+<0.1%) ⬆️

@jiridanek
Copy link
Contributor

Not sure how dependency resolution works in cargo, since apparently updating bollard (Docker API client library) causes a compilation failure (probably) from tokio about not enabled rt-multi-thread feature.

Anyways, the fix should not be hard, one line in project config file to enable this rt-multi-thread thing.
I'll do it later.

   Compiling skupper-router v0.0.0 (/home/runner/work/skupper-router/skupper-router)
error: The runtime flavor `multi_thread` requires the `rt-multi-thread` feature.
  --> tests/testcontainers/test_h2spec.rs:82:1
   |
82 | #[tokio::test(flavor = "multi_thread")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the attribute macro `tokio::test` (in Nightly builds, run with -Z macro-backtrace for more info)

error: The runtime flavor `multi_thread` requires the `rt-multi-thread` feature.
  --> tests/testcontainers/test_skrouterd_sanity.rs:39:1
   |
39 | #[tokio::test(flavor = "multi_thread")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the attribute macro `tokio::test` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `skupper-router` (test "testcontainers") due to 2 previous errors
Error: Process completed with exit code 101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant