Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1494: add verbose TLS logging to diagnose stall #1500

Merged
merged 1 commit into from
May 16, 2024

Conversation

kgiusti
Copy link
Contributor

@kgiusti kgiusti commented May 15, 2024

This does not solve the issue. Additional logging will help us root cause the issue. This commit may be reverted after #1494 is resolved for performance improvement.

This does not solve the issue. Additional logging will help us root
cause the issue. This commit may be reverted after skupperproject#1494 is resolved
for performance improvement.
@ganeshmurthy
Copy link
Contributor

ganeshmurthy commented May 15, 2024

Since TLS is meant to go only over TCP and this adaptor tls module will not be used by any other adaptor, can the tls->log_module be replaced with LOG_TCP_ADAPTOR or perhaps introduce something like a LOG_TCP_TLS log module and the calls to qd_log_impl() be replaced with a simple qd_log()?

This above comment is unrelated to this PR but I just had that thought. This PR is ready to go.

@kgiusti kgiusti merged commit 262ec00 into skupperproject:main May 16, 2024
39 of 41 checks passed
@kgiusti kgiusti deleted the ISSUE-1494 branch May 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ncat TCP TLS test fails due to inbound data stall on connector-side inbound flow
2 participants