Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage] Collect failure message #3560

Merged
merged 4 commits into from
May 17, 2024
Merged

[Usage] Collect failure message #3560

merged 4 commits into from
May 17, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 16, 2024

We used sys.exit(1) for CLIs like sky local up which will cause the error message failed to be exposed by the usage collection. We now change them to error raising for more complete error message.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Manually added an error in local up script and check the failure appear in usage collection
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll!

tests/test_jobs_and_serve.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit d09b6dc into master May 17, 2024
20 checks passed
@Michaelvll Michaelvll deleted the expose-local-up-error branch May 17, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants