Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clarify managed spot jobs against sky launch #3561

Merged
merged 8 commits into from
May 19, 2024

Conversation

Michaelvll
Copy link
Collaborator

We add a hint box for managed spot jobs comparing to sky launch --use-spot in docs.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo May 17, 2024 05:36
.. tip::

:code:`sky launch --use-spot` is a "serverful" command that launches a cluster for
running jobs, where recoveries of the cluster after preemptions is user's responsibility. In contrast, managed spot jobs, :code:`sky jobs launch --use-spot`, is a "serverless" command, where SkyPilot is in charge of the whole
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
running jobs, where recoveries of the cluster after preemptions is user's responsibility. In contrast, managed spot jobs, :code:`sky jobs launch --use-spot`, is a "serverless" command, where SkyPilot is in charge of the whole
running jobs, where the cluster will not be recovered after preemptions. In contrast, managed spot jobs, :code:`sky jobs launch --use-spot`, is a "serverless" command, where SkyPilot is in charge of the whole

not feeling strongly; just "reciver is user's responsibility" sounds a little bit weird for me

@@ -23,6 +23,12 @@ Managed Spot Jobs
SkyPilot automatically finds available spot resources across regions and clouds to maximize availability.
Any spot preemptions are automatically handled by SkyPilot without user intervention.

.. tip::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: this para is a bit too long to skim. How about a short sentence followed by a table?

Command  Managed?   SSH-able?  Best for
`sky launch --use-spot`   Unmanaged spot cluster   Yes   Interactive dev on spot instances
`sky jobs launch --use-spot`    Managed spot job (auto-recovery)   No   Scaling out long-running jobs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Changed it accordingly:
image

Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some suggestions. Thanks @Michaelvll.

docs/source/examples/managed-jobs.rst Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
docs/source/examples/managed-jobs.rst Outdated Show resolved Hide resolved
Michaelvll and others added 5 commits May 18, 2024 21:09
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
@Michaelvll Michaelvll merged commit 19e8ed1 into master May 19, 2024
20 checks passed
@Michaelvll Michaelvll deleted the hint-managed-spot-jobs branch May 19, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants