Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use sweepers #2132

Merged
merged 1 commit into from
Dec 28, 2021
Merged

refactor: use sweepers #2132

merged 1 commit into from
Dec 28, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Nov 24, 2021

This PR depends on discordjs/discord.js#6825 and bumps discord.js to latest commit in the PR's branch. One of the biggest upsides of this update, is that both CPU and RAM usage are in theory, noticeably lower.

⚠️ This Pull Request requires skyra-project/editable-commands#68 in order to work

favna
favna previously approved these changes Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #2132 (561347d) into main (a4f3935) will not change coverage.
The diff coverage is n/a.

❗ Current head 561347d differs from pull request most recent head 33ac5b4. Consider uploading reports for the commit 33ac5b4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files         125      125           
  Lines        5741     5741           
  Branches      370      370           
=======================================
  Hits         5276     5276           
  Misses        463      463           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f3935...33ac5b4. Read the comment docs.

tests/lib/bits.test.ts Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@favna favna force-pushed the chore/use-sweepers branch 2 times, most recently from 5d28875 to 6d0e7f2 Compare December 28, 2021 18:40
fix: override makeCache
fix: resolved lint error
fix: resolved build error

Co-authored-by: ckohen <chaikohen@gmail.com>
@favna favna marked this pull request as ready for review December 28, 2021 19:09
@favna favna changed the title chore: use sweepers refactor: use sweepers Dec 28, 2021
@favna favna merged commit c79a519 into main Dec 28, 2021
@favna favna deleted the chore/use-sweepers branch December 28, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants