Parse string or boolean for SlashCommand.IsEnterpriseInstall #1266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom JSON parser for the
SlashCommand
struct to work correctly when"is_enterprise_install"
comes in as either a string or a boolean. As noted in the issue, in socket mode, certain (but not all 🤷) payloads have"is_enterprise_install"
as a quoted boolean (e.g."false"
) whereas others have it as an actual boolean (e.g.false
).This doesn't update the
IsEnterpriseInstall
field inSlashCommand
itself, so this change should be transparent to anyone who might have started using that newly added field.Fixes #1265
Prior fix attempt: #1264
Testing: