Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2056 by adding files to app_mention payload #2057

Merged
merged 1 commit into from Feb 13, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Feb 13, 2024

Summary

This pull request resolves #2056

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Feb 13, 2024
@seratch seratch added this to the 3.18.0 milestone Feb 13, 2024
@seratch seratch self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b413520) 81.97% compared to head (01374c6) 81.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2057   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          18       18           
  Lines        1531     1531           
  Branches      440      440           
=======================================
  Hits         1255     1255           
  Misses        178      178           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! Thanks for putting in this fix 🙇

@seratch seratch merged commit 449eced into slackapi:main Feb 13, 2024
8 checks passed
@seratch seratch deleted the issue-2056-files-in-app-mention branch February 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

files property missing in app_mention event
2 participants