Add CodeCov reporting back after a 3 year hiatus #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cli-hooks dev deps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 94.41% 88.58% -5.84%
==========================================
Files 12 18 +6
Lines 806 6148 +5342
Branches 178 297 +119
==========================================
+ Hits 761 5446 +4685
- Misses 15 690 +675
+ Partials 30 12 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
filmaj
added
semver:patch
enhancement
filmaj
changed the title
zimeg
approved these changes
May 14, 2024
| @@ -32,15 +32,28 @@ jobs: | |||
| - name: Get Development Dependencies | |||
| run: npm i | |||
| - name: Build and Run Tests in Each Package | |||
| working-directory: ${{ matrix.package }} | |||
| working-directory: packages/${{ matrix.package }} | |||
Comment on lines
+58
to
+59
| flags: ${{ matrix.package }} | ||
| verbose: true |
Comment on lines
+1
to
+2
| comment: | ||
| layout: "condensed_header, diff, flags" |
| @@ -65,6 +65,7 @@ | |||
| "eslint-plugin-node": "^11.1.0", | |||
| "mocha": "^10.2.0", | |||
| "shx": "^0.3.4", | |||
| "sinon": "^17.0.1" | |||
| "sinon": "^17.0.1", | |||
| "typescript": "5.4.5" | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should bring codecov reporting back in for node-slack-sdk; woot!
nycas the coverage tool, replaced withc8, it hasn't been updated in 4 years andc8is essentially a drop-in replacement and maintained. Hat tip to @zimeg as I just followed their lead in thepackages/cli-hookssub-package.