Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CLI test utility bindings #1789

Merged
merged 24 commits into from
May 23, 2024
Merged

add CLI test utility bindings #1789

merged 24 commits into from
May 23, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented May 16, 2024 •
edited

TODO

  • figure out versioning
  • refactor CLI commands out into separate files
  • better readme
  • codecov badge in readme

@filmaj filmaj added the draft label May 16, 2024
@filmaj filmaj self-assigned this May 16, 2024
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 46.36752% with 753 lines in your changes are missing coverage. Please review.

Project coverage is 80.73%. Comparing base (4d45007) to head (83ce07b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
- Coverage   88.58%   80.73%   -7.85%     
==========================================
  Files          18       35      +17     
  Lines        6148     7552    +1404     
  Branches      297      308      +11     
==========================================
+ Hits         5446     6097     +651     
- Misses        690     1443     +753     
  Partials       12       12
Flag Coverage Δ
cli-hooks 95.07% <ø> (ø)
cli-test 46.36% <46.36%> (?)
oauth 76.51% <ø> (ø)
socket-mode 59.41% <ø> (ø)
web-api 96.48% <ø> (ø)
webhook 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj added the pkg:cli-test applies to `@slack/cli-test` label May 16, 2024
filmaj added 14 commits May 16, 2024 15:08
@filmaj
start factoring out bits into their own files, start on a SlackCLIPro…
c3ee05b 
…cess class to handle Slack CLI specifics like supported flags
@filmaj
Assertion helpers should probably not be the domain of this library
909c768
@filmaj
fix up eslint for cli-test, further work specifying a process class, …
5904fa2 
…more details on global vs. command flag modeling
@filmaj
note on versioning in the maintainers guide.
2bfa651
@filmaj
add cli-process tests.
0c331a2
@filmaj
use true for standalone flags.
38f2a86
@filmaj
dry up some shell stuff, use true for standalone flags in sub commands.
8fd6505
@filmaj
use true for standalone flags
900e595
@filmaj
splitting commands out: collabs, env, platform, trigger
4f346c7
@filmaj
add exec-until-string-present to SlackCLIProcess, activity methods ad…
3a734b1 
…ded to platform file, trigger access and remove to trigger file, function access to a new funciton file.
@filmaj
refactor complete?
c2d0f9a
@filmaj
rc2, export SlackProduct constants, prepare package.json for public r…
064b6a2 
…elease.
@filmaj
expose shell options to create command
e101bb5
@filmaj
rc3
8e80ab0
@filmaj filmaj changed the title WIP: add CLI test utility bindings add CLI test utility bindings May 23, 2024
@filmaj filmaj removed the draft label May 23, 2024
@filmaj filmaj merged commit 0f38f72 into main May 23, 2024
19 of 21 checks passed
@filmaj filmaj deleted the cli-test branch May 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@filmaj filmaj

Labels
pkg:cli-test applies to `@slack/cli-test` semver:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@filmaj