Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to K2 #1006

Merged
merged 102 commits into from
May 28, 2024
Merged

Update to K2 #1006

merged 102 commits into from
May 28, 2024

Conversation

ZacSweers
Copy link
Collaborator

@ZacSweers ZacSweers commented Nov 20, 2023 •
edited

  • Update to Kotlin 2.0.0
  • Update to KSP 2.0.0-1.0.21
  • Update to Compose Multiplatform 1.6.10
  • Switch to the compose compiler shipped with Kotlin.

Will wait until after the next release is cut since we have a lot already unreleased on main

@ZacSweers

This comment was marked as resolved.

Sign in to view
@ZacSweers
Copy link
Collaborator Author

Held up on https://youtrack.jetbrains.com/issue/KT-64187

@ZacSweers
Copy link
Collaborator Author

No compose multiplatform support for Beta3 so far, makes it more or less impossible to continue testing this for now JetBrains/compose-multiplatform#4227

@ZacSweers
Copy link
Collaborator Author

Ok there was a beta3, but need to wait for beta4 for the expect/actual fixes: https://youtrack.jetbrains.com/issue/KT-64187

@ZacSweers
Copy link
Collaborator Author

Waiting for a compose-compiler Beta4 release on https://maven.pkg.jetbrains.space/public/p/compose/dev/org/jetbrains/compose/compiler/compiler/

@ZacSweers ZacSweers mentioned this pull request May 23, 2024
Closed
@ZacSweers
Copy link
Collaborator Author

ZacSweers commented May 23, 2024 •
edited

Compose Multiplatform appears to have published 1.6.10 depending on a pre-release stdlib dep JetBrains/compose-multiplatform#4853

KSP published broken dependencies google/ksp#1917

@ZacSweers ZacSweers changed the title Prepare for K2 Update to K2 May 23, 2024
@ZacSweers ZacSweers requested a review from stagg May 23, 2024 04:06
@ZacSweers ZacSweers marked this pull request as ready for review May 23, 2024 04:06
@ZacSweers ZacSweers enabled auto-merge May 28, 2024 04:27
@ZacSweers ZacSweers disabled auto-merge May 28, 2024 04:27
@ZacSweers ZacSweers enabled auto-merge May 28, 2024 15:34
@ZacSweers ZacSweers added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 8e79b2a May 28, 2024
6 checks passed
@ZacSweers ZacSweers deleted the z/k2 branch May 28, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stagg stagg stagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZacSweers @mslalith @stagg