WIP - Shared elements experimenting #1330
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riggaroo
reviewed
Apr 16, 2024
Comment on lines
126
to
132
| .sharedBounds( | ||
| sharedContentState = rememberSharedContentState(key = "animal-${state.id}"), | ||
| animatedVisibilityScope = sharedElementAnimatedContentScope(), | ||
| ) | ||
| .sharedElement( | ||
| state = rememberSharedContentState(key = "animal-image-${state.id}"), | ||
| animatedVisibilityScope = sharedElementAnimatedContentScope(), |
There was a problem hiding this comment.
Is there a particular reason why you are adding both sharedBounds and sharedElement on this item?
There was a problem hiding this comment.
Nope! Was moving them around and alternating between the two.
- Interceptor to set the animation - Interceptor to setup shared elements - Add a new `thenIfSharedTransitionScope` modifier to use shared element api's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with the new shared elements api over in the star sample to avoid some KMP stuff.
Right now this has two locals for the current scopes, need to clean that up a bit 馃槄
Q's
Demo
shared.mp4