Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.jetbrains.compose.compiler:compiler to v1.5.13.3 #1399

Merged
merged 8 commits into from
May 19, 2024

Conversation

slack-oss-bot
Copy link
Collaborator

@slack-oss-bot slack-oss-bot commented May 8, 2024

This PR contains the following updates:

Package Type Update Change
org.jetbrains.compose.compiler:compiler dependencies patch 1.5.10.2 -> 1.5.13.3

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

JetBrains/compose-jb (org.jetbrains.compose.compiler:compiler)

v1.5.12

Common

Features

Desktop

Fixes

Dependencies

This version of Compose Multiplatform is based on the next Jetpack Compose libraries:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@slack-oss-bot slack-oss-bot changed the title Update dependency org.jetbrains.compose.compiler:compiler to v1.5.13.1 Update dependency org.jetbrains.compose.compiler:compiler to v1.5.13.3 May 11, 2024
@ZacSweers ZacSweers disabled auto-merge May 13, 2024 19:27
@ZacSweers ZacSweers enabled auto-merge May 13, 2024 20:02
@slack-oss-bot
Copy link
Collaborator Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@ZacSweers
Copy link
Collaborator

Folding into #1416

@ZacSweers ZacSweers closed this May 19, 2024
auto-merge was automatically disabled May 19, 2024 04:06

Pull request was closed

@ZacSweers ZacSweers deleted the renovate/compose.jb.compiler branch May 19, 2024 04:07
@ZacSweers ZacSweers restored the renovate/compose.jb.compiler branch May 19, 2024 04:19
@ZacSweers ZacSweers reopened this May 19, 2024
@ZacSweers ZacSweers enabled auto-merge May 19, 2024 04:20
@ZacSweers
Copy link
Collaborator

Pasting what I asked elsewhere

I noticed a subtle change that surprised me. The behavior might be correct, but I don’t fully understand why. The snippet I’m testing this is:

Column {
  var text2Enabled by rememberRetained { mutableStateOf(true) }
  val text1 by rememberRetained { mutableStateOf("Text") }
  Text(modifier = Modifier.testTag(TAG_RETAINED_1), text = text1)
  Button(
    modifier = Modifier.testTag("TAG_BUTTON"),
    onClick = { text2Enabled = !text2Enabled },
  ) {
    Text("Toggle")
  }
  if (text2Enabled) {
    val text2 by rememberRetained { mutableStateOf("Text") }
    Text(modifier = Modifier.testTag(TAG_RETAINED_2), text = text2)
  }
}

On 1.5.10.2, the first two rememberRetained calls have the same currentCompositeKeyHash , and the third one (under text2Enabled) is different.

On 1.5.13.3, all three of them have the same currentCompositeKeyHash. Is that expected? I’d expect the if-statement to change the key here like it did on 1.5.10.2.

This is what is causing that test to fail, as it previously assumed two different hash keys. It's not super relevant to the test, but wanna understand it better before proceeding.

@ZacSweers
Copy link
Collaborator

Actually, my last comment on that line suggests it was supposed to be one entry all along

@ZacSweers ZacSweers added this pull request to the merge queue May 19, 2024
Merged via the queue into main with commit dba5686 May 19, 2024
6 checks passed
@ZacSweers ZacSweers deleted the renovate/compose.jb.compiler branch May 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants