add AsyncMysqlQueryErrorResult and SQLFakeAsyncMysqlException #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbibra
commented
Oct 4, 2023
| public function __construct(private int $mysql_errno = 1105, private string $mysql_error = 'ERUnknownError') {} | ||
|
|
||
| <<__Override>> | ||
| // HHAST_IGNORE_ERROR[CamelCasedMethodsUnderscoredFunctions] |
There was a problem hiding this comment.
need this because the parent method is not camel cased
brirams
reviewed
Oct 6, 2023
Comment on lines
+6
to
+8
| /* HH_IGNORE_ERROR[3012] I don't want to call parent::construct */ | ||
| public function __construct(private int $mysql_errno = 1105, private string $mysql_error = 'ERUnknownError') {} | ||
|
|
There was a problem hiding this comment.
think we can get away with calling the parent constructor here and removing the ignore:
parent::__construct();
There was a problem hiding this comment.
We can't do that here because the parent constructor is a private method [FATAL] E_FATAL: Call to private method AsyncMysqlQueryErrorResult::__construct()
brirams
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
AsyncMysqlQueryErrorResultandSQLFakeAsyncMysqlExceptionto help verify mysql errors in tests.Issue: #109