Fix elapsedMicros always returning zero #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$this->start` and `$this->end` have the same unit, inferred via `endTime()`. That function adds the two without doing a unit conversion first. `$this->start` has the unit seconds. `elapsedMicros()` used to divide by 1_000_000 and return megaseconds. By swapping the division with a multiplication, `elapsedMicros()` now returns microseconds.
|
Thanks for the contribution! Before we can merge this, we need @lexidor to sign the Salesforce Inc. Contributor License Agreement. |
K128kevin
reviewed
Apr 27, 2023
K128kevin
approved these changes
Apr 28, 2023
muglug
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->startand$this->endhave the same unit, inferred viaendTime(). That function adds the two without doing a unit conversion first.$this->starthas the unit seconds.elapsedMicros()used to divide by 1_000_000 and return megaseconds. By swapping the division with a multiplication,elapsedMicros()now returns microseconds.