Remove support for XRegExp.install('natives')
#207
Merged
+35
−735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
slevithan
reviewed
Jan 2, 2018
tests/perf/perf.js
Outdated
| XRegExp.install('natives'); | ||
| var fixedExec = RegExp.prototype.exec; | ||
| XRegExp.uninstall('natives'); | ||
| var fixedExec = XRegExp.exec; |
There was a problem hiding this comment.
The 3 cases below of comparing "shimmed exec" to XRegExp.exec are no longer testing different things. I'd recommend removing the fixedExec var entirely and the 3 .add calls that use it.
There was a problem hiding this comment.
Oh, good point! I was essentially doing a naive search/replace on the code, so I didn't notice this. Fixed in 9f21bd0
speecyy
added a commit
to speecyy/xregexp
that referenced
this pull request
Jan 6, 2018
3590212051
added a commit
to 3590212051/POPmotion
that referenced
this pull request
Jan 8, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #89