Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Handle ES2018 capture names #247

Merged
merged 14 commits into from Jan 9, 2021
Merged

BREAKING: Handle ES2018 capture names #247

merged 14 commits into from Jan 9, 2021

Commits on Jan 9, 2021

  1. Update tests to show API changes

    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    dff32fe View commit details
    Browse the repository at this point in the history

  2. Use RegExpIdentifierName without escape sequences for named captures/… 

    …backreferences
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    c324a75 View commit details
    Browse the repository at this point in the history

  3. Update build tools to make it actually work

    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    1e000ef View commit details
    Browse the repository at this point in the history

  4. Remove now-unnecessary bare integer check from named capture group pa… 

    …rser, see slevithan#247 (comment)
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    101d4c7 View commit details
    Browse the repository at this point in the history

  5. Just say RegExpIdentifierName instead of listing alphnumeric/$_, see h… 

    …ttps://github.com/slevithan/xregexp/pull/247/files#r554330786
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    b489e50 View commit details
    Browse the repository at this point in the history

  6. Test operation of named capture groups, not just construction, see ht… 

    …tps://github.com/slevithan/xregexp/pull/247/files#r554332286
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    50d95f9 View commit details
    Browse the repository at this point in the history

  7. Reference "RegExpIdentifierName characters" instead of listing the na… 

    …rrower set, see https://github.com/slevithan/xregexp/pull/247/files#r554333301
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    35a63a6 View commit details
    Browse the repository at this point in the history

  8. Don't disallow numbered backreferences like \k<1>, see https://github… 

    ….com/slevithan/xregexp/pull/247/files#r554340317
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    c68536e View commit details
    Browse the repository at this point in the history

  9. Restore tests of explicit numbered backreferences, see https://github… 

    ….com/slevithan/xregexp/pull/247/files#r554341172
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    b20cadd View commit details
    Browse the repository at this point in the history

  10. Reallow explicit numbered backreferences in replacement text, see htt… 

    …ps://github.com/slevithan/xregexp/pull/247/files#r554312167
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    86318d4 View commit details
    Browse the repository at this point in the history

  11. Reallow numbered backreferences in patterns, see https://github.com/s… 

    …levithan/xregexp/pull/247/files#r554343245
    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    574a5bb View commit details
    Browse the repository at this point in the history

  12. Restore s-xregexp-methods.js

    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    4eee345 View commit details
    Browse the repository at this point in the history

  13. Update code comments, see slevithan#247 (review)

    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    6ff1615 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into test-node-10

    @josephfrazier
    josephfrazier committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    6ecf26c View commit details
    Browse the repository at this point in the history