Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @babel/runtime-corejs3 #280

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

josephfrazier
Copy link
Collaborator

Fixes #279

@slevithan
Copy link
Owner

@josephfrazier, do you know why the failure? Feel free to go ahead and land build or other improvements, and/or publish new tags/releases, without review.

@josephfrazier
Copy link
Collaborator Author

Hmm, not sure. Here's the error, for reference:

> browserify lib/index.js --standalone XRegExp > xregexp-all.js
Error: Cannot find module '@babel/runtime-corejs2/helpers/interopRequireDefault' from '/home/travis/build/slevithan/xregexp/lib'
    at /home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:46:17
    at process (/home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:188:17)
    at load (/home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
    at /home/travis/build/slevithan/xregexp/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:170:21)

I'll see if I can figure it out.

Feel free to go ahead and land build or other improvements, and/or publish new tags/releases, without review

Thanks! I'll have to remember the entire release process, but I think we have it written down in an issue/PR somewhere.

@josephfrazier
Copy link
Collaborator Author

Though, it looks like I don't have permission to publish on NPM, so I'll still have to ask you to do that, unless you want to add me as an owner.

@slevithan slevithan merged commit 2662b2b into slevithan:master Jan 30, 2020
@slevithan
Copy link
Owner

@josephfrazier

Here’s the list of steps: #205 (comment).

I’ve also just added you as an xregexp npm maintainer via npmjs.com.

Thanks for all your help with this!

@tdjastrzebski
Copy link

Will the new version 4.2.x be published on npmjs.com?

@humphreyn
Copy link

@josephfrazier & @slevithan ,
Great work guys. Hopefully as @tdjastrzebski asked you will be publishing this new version on NPM soon

@josephfrazier josephfrazier deleted the babel.runtime.corejs3 branch February 4, 2020 21:20
@josephfrazier
Copy link
Collaborator Author

Thanks @slevithan, I'm going to start preparing a new minor release (v4.3.0) following the steps you linked. For reference, here are the changes that will be included (Unicode 12.1.0 and @babel/runtime-corejs3): v4.2.4...master

If all goes well, I'll probably publish to NPM sometime this week.

josephfrazier added a commit to josephfrazier/xregexp that referenced this pull request Feb 5, 2020
Changes include:

* Upgrading from Unicode 11.0.0 to Unicode 12.1.0: slevithan#278
* Upgrading from `@babel/runtime-corejs2` to `@babel/runtime-corejs3`: slevithan#280

To generate this commit, I followed the steps at slevithan#205 (comment)

See more context at slevithan#280 (comment)
@josephfrazier josephfrazier mentioned this pull request Feb 5, 2020
@tdjastrzebski
Copy link

If I could advise something: include typescript definitions.

@josephfrazier
Copy link
Collaborator Author

Hey @tdjastrzebski, I'm happy to include typescript definitions in a future release, but I don't have enough TS experience to add them myself. Do you know anyone who can help out?

@tdjastrzebski
Copy link

tdjastrzebski commented Feb 6, 2020

@josephfrazier: @Bartvds, @jfahrenkrug or @sigo may be able to help.
I think they maintain xregexp typescript defs for ver 3.0 available at https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/xregexp
I think these days it makes way more sense to include typescript defs with the package.

@jfahrenkrug
Copy link
Contributor

@tdjastrzebski I'd be happy to help with including the TS defs in the package. Maybe open a new ticket for it?

@tdjastrzebski
Copy link

@jfahrenkrug see #284

josephfrazier added a commit that referenced this pull request Feb 11, 2020
Changes include:

* Upgrading from Unicode 11.0.0 to Unicode 12.1.0: #278
* Upgrading from `@babel/runtime-corejs2` to `@babel/runtime-corejs3`: #280

To generate this commit, I followed the steps at #205 (comment)

See more context at #280 (comment)
@josephfrazier
Copy link
Collaborator Author

Thanks @slevithan, I'm going to start preparing a new minor release (v4.3.0) following the steps you linked. For reference, here are the changes that will be included (Unicode 12.1.0 and @babel/runtime-corejs3): v4.2.4...master

If all goes well, I'll probably publish to NPM sometime this week.

Just published v4.3.0: https://www.npmjs.com/package/xregexp/v/4.3.0

@josephfrazier: @Bartvds, @jfahrenkrug or @sigo may be able to help.
I think they maintain xregexp typescript defs for ver 3.0 available at DefinitelyTyped/DefinitelyTyped:types/xregexp@master
I think these days it makes way more sense to include typescript defs with the package.

I'll try to take a look at the PRs for this and see if we can get TS defs into the next release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on core-js@2 which is no longer maintend
5 participants