SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation…

…: Fixed false positive with self::CONSTANT
slevomat · Oct 22, 2022 · 080f592 · 080f592
1 parent 71dddfe
commit 080f592
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php b/SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php
@@ -109,6 +109,10 @@ public function process(File $phpcsFile, $docCommentOpenPointer): void
 							? $constantFetchNode->className
 							: $constantFetchNode->name;
 
+						if ($typeHint === 'self') {
+							continue;
+						}
+
 						$fullyQualifiedTypeHint = $isClassConstant
 							? NamespaceHelper::resolveClassName(
 								$phpcsFile,

diff --git a/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php b/tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php
@@ -178,7 +178,7 @@ public function withNever()
 }
 
 /**
- * @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC)
+ * @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC, int $flags = self::FLAG)
  */
 class ConstantExpression
 {