Skip to content

Commit

Permalink
GH Actions: turn error reporting on
Browse files Browse the repository at this point in the history
The default ini file used by the SetupPHP action is the production one, which turns error_reporting/display off.

For the purposes of CI, I'd recommend running with `error_reporting=-1` and `display_errors=On` to ensure **all** PHP notices are shown.

Also see: shivammathur/setup-php#469
  • Loading branch information
jrfnl authored and kukulich committed Oct 4, 2023
1 parent e45d3f2 commit 40ede62
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Expand Up @@ -41,6 +41,7 @@ jobs:
with:
coverage: "none"
php-version: "${{ matrix.php-version }}"
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1

- name: "Reset composer platform"
if: matrix.php-version == '7.2' || matrix.php-version == '7.3' || matrix.php-version == '7.4'
Expand Down Expand Up @@ -77,6 +78,7 @@ jobs:
with:
coverage: "none"
php-version: "${{ matrix.php-version }}"
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1

- name: "Install dependencies"
uses: "ramsey/composer-install@v2"
Expand Down Expand Up @@ -152,6 +154,7 @@ jobs:
coverage: "none"
php-version: "${{ matrix.php-version }}"
extensions: mbstring
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1

- name: "Reset composer platform"
if: matrix.php-version == '7.2' || matrix.php-version == '7.3' || matrix.php-version == '7.4' || matrix.php-version == '8.0'
Expand Down Expand Up @@ -188,6 +191,7 @@ jobs:
with:
coverage: "pcov"
php-version: "${{ matrix.php-version }}"
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1

- name: "Install dependencies"
uses: "ramsey/composer-install@v2"
Expand Down

0 comments on commit 40ede62

Please sign in to comment.