refactor(reverse): dockerfilefromhistory default processor #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test and refactor the default case for the raw instruction processor, this change identify the values affected (`inst`and `isExecForm`), and extracts the case body out to a new function. Signed-off-by: Dennis Walters <dwaltersii@gmail.com>
Added unit tests for the function that was previously extracted from `DockerfileFromHistory` to ensure refactored behavior. Signed-off-by: Dennis Walters <dwaltersii@gmail.com>
* Extracts `processAsUncaughtInst` for handling standard instructions that were given in a non-standard form (as may happen with buildkit, etc) * Extracts `processAsArgsFormat` for handling RUN instructions that were provided in the args format * Extracts `processAsExecRun` for handling commands that were provided in a non-standard way * Extracts `detectRawShellForm` for detecting commands that are shaped like shell form RUN instructions * Extracts `execify` for converting arrays of strings to exec format RUN instructions (and lowering code duplication) * Replaces the body of `processRawInst` to incorporate these extracted functions and generally make the problem easier to reason about and extend Signed-off-by: Dennis Walters <dwaltersii@gmail.com>
Signed-off-by: Dennis Walters <dwaltersii@gmail.com>
Signed-off-by: Dennis Walters <dwaltersii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the desire expressed in the
TODOin the default raw instruction processing case inDockerfileFromHistory, this adds tests for that processor and refactors it.The end result increases cumulative cyclomatic complexity a few points, but generally drops the complexity of the individual pieces through conditional flattening and code deduplication, provides a clear path towards extension, and generally makes the default processor a good deal easier to reason about.