Move private header in a private directory #3157
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As to make more obvious that these header are private
ogoffart
commented
Jul 25, 2023
Comment on lines
+283
to
+284
| $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/generated_include/private> | ||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include/private> |
There was a problem hiding this comment.
Because of this, this doesn't have the expected effect when using FetchContent_Declare, as the private is in the include path :-(
ogoffart
force-pushed
the
olivier/cpp
branch
2 times, most recently
from
95d6ffe
to
45146d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As to make more obvious that these header are private