Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #14

Merged
merged 1 commit into from May 28, 2023
Merged

update dependencies #14

merged 1 commit into from May 28, 2023

Conversation

figsoda
Copy link
Contributor

@figsoda figsoda commented May 12, 2023

prodash was not updated since codevis 0.8.3 still depends on prodash 20

@sloganking sloganking self-requested a review May 13, 2023 22:25
@sloganking
Copy link
Owner

@figsoda

@figsoda
Copy link
Contributor Author

figsoda commented May 28, 2023

@sloganking I think you might have forgotten your message

@sloganking
Copy link
Owner

sloganking commented May 28, 2023

@sloganking I think you might have forgotten your message

@figsoda What is the reason this was changed from clap to arg? It seems to still work find if I replace it with clap again.

@figsoda
Copy link
Contributor Author

figsoda commented May 28, 2023

see clap-rs/clap#4180, even though #[clap()] still works, #[arg()] and #[command()] are now recommended since clap v4

@@ -5,30 +5,30 @@ pub struct Args {
/// An example:
///
/// https://github.com/sloganking/codemov
#[clap(long, short = 'r', help_heading = "INPUT")]
#[arg(long, short = 'r', help_heading = "INPUT")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason this was changed from clap to arg? It seems to still work find if I replace it with clap again.

@sloganking sloganking merged commit ab4b287 into sloganking:master May 28, 2023
1 check passed
@sloganking
Copy link
Owner

@figsoda Got it. Thanks for the PR!

@figsoda figsoda deleted the update branch May 28, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants