Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference Gradle workflow. #1240

Merged
merged 1 commit into from Nov 18, 2022

Conversation

DanAlbert
Copy link
Contributor

Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to set the run-on in the README?

@DanAlbert
Copy link
Contributor Author

Not sure what you mean. I added https://github.com/slsa-framework/slsa-github-generator/pull/1240/files#diff-16f6a396627c41a481fce367ef13571a35d92d30d9d470b7d9956c0c49cf9a6bR672. Did I miss some other doc? Possibly, but this section should probably be copy/paste-able :)

@laurentsimon
Copy link
Collaborator

Not sure what you mean. I added https://github.com/slsa-framework/slsa-github-generator/pull/1240/files#diff-16f6a396627c41a481fce367ef13571a35d92d30d9d470b7d9956c0c49cf9a6bR672. Did I miss some other doc? Possibly, but this section should probably be copy/paste-able :)

SG. Did not show when I opened the page earlier. I probably missed it. Thanks!

@laurentsimon laurentsimon merged commit 10cb4de into slsa-framework:main Nov 18, 2022
@DanAlbert DanAlbert deleted the fix-gradle-docs branch November 18, 2022 22:13
@ianlewis ianlewis mentioned this pull request Nov 21, 2022
ianlewis added a commit that referenced this pull request Nov 28, 2022
I thought for sure we had fixed all these.

Related: #1240 

Signed-off-by: Ian Lewis <ianlewis@google.com>

Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants