Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update softprops/action-gh-release to v2.0.5 #3619

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented May 11, 2024

Summary

To resolve the deprecation warning of Node.js v16.
softprops/action-gh-release updated Node.js to v20 at v2.0.0.

https://github.com/softprops/action-gh-release/releases/tag/v2.0.0

Node.js 16 was deprecated.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

So we need to update softprops/action-gh-release to v2.0.0 or newer.

Currently, slsa-framework/slsa-github-generator outputs the following warning.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Testing Process

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

To resolve the deprecation warning of Node.js v16.
softprops/action-gh-release updated Node.js to v20 at v2.0.0.

https://github.com/softprops/action-gh-release/releases/tag/v2.0.0

Node.js 16 was deprecated.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

So we need to update softprops/action-gh-release to v2.0.0 or newer.

Currently, slsa-framework/slsa-github-generator outputs the following warning.

```
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: softprops/action-gh-release@de2c0eb. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ramonpetgrave64 ramonpetgrave64 merged commit 1e31946 into slsa-framework:main May 14, 2024
74 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the chore-update-action-gh-release-205 branch May 14, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants