Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cookies on acme client #1834

Closed
wants to merge 1 commit into from
Closed

Enable cookies on acme client #1834

wants to merge 1 commit into from

Conversation

arontsang
Copy link

@arontsang arontsang commented May 8, 2024 •
edited

Fixes #1833

@CLAassistant
Copy link

CLAassistant commented May 8, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 8, 2024
@hslatman hslatman self-requested a review May 14, 2024 17:04
@hslatman hslatman self-assigned this May 14, 2024
@hslatman hslatman mentioned this pull request May 15, 2024
Closed
@hslatman
Copy link
Member

As discussed in #1833, this is not the right fix.

@hslatman hslatman closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hslatman hslatman Awaiting requested review from hslatman

Assignees

@hslatman hslatman

Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an in-memory cookie jar to http.Client returned by NewClient
3 participants
@arontsang @CLAassistant @hslatman