Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify provisioner with id if available #1844

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

maraino
Copy link
Contributor

@maraino maraino commented May 14, 2024

This commit allows verifying the account provisioner with the request provisioner using the ID instead of the name. When the provisioner are stored in the DB, the provisioner ID is not mutable but the name is.

This commit allows verifying the account provisioner with the request
provisioner using the ID instead of the name. When the provisioner are
stored in the DB, the provisioner ID is not mutable but the name is.
@maraino maraino requested a review from hslatman May 14, 2024 00:12
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 14, 2024
acme/api/middleware.go Outdated Show resolved Hide resolved
@maraino maraino requested a review from hslatman May 15, 2024 23:12
hslatman
hslatman previously approved these changes May 16, 2024
@maraino maraino merged commit ad0ac55 into master May 16, 2024
13 checks passed
@maraino maraino deleted the mariano/account-provisioner branch May 16, 2024 21:40
Copy link
Member

@hslatman hslatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄

@hslatman hslatman added this to the v0.26.2 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants