Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows logging errors in a
slog.Logger
injected in the context. This logger type is not currently used directly in step-ca, but this will change in the future.The main change is in
api/log/log.go
; the rest is adapting the code to allow this.I've considered using
func Error(ctx context.Context, w http.ResponseWriter, err error)
, but this won't allow us to add extra things from the request to the log if we need to.I've also had to change the render methods because they can call
Error
.cc: @hslatman