Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting ssh key types #1156

Merged
merged 1 commit into from
May 14, 2024

Conversation

redrac
Copy link
Contributor

@redrac redrac commented Apr 20, 2024

Name of feature:

Add --kty, --curve, and --size to ssh commands (login, certificate)

Pain or issue this feature alleviates:

Allow users flexibility to control their SSH key configuration

Supporting links/other PRs/issues:

implements feature request from #477

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Apr 20, 2024
@redrac redrac force-pushed the feature/add_ssh_key_type_control branch 6 times, most recently from cdd42a4 to 3436971 Compare April 23, 2024 14:20
@hslatman hslatman requested a review from maraino April 23, 2024 17:15
@redrac redrac force-pushed the feature/add_ssh_key_type_control branch 2 times, most recently from c2e6fde to 09bd694 Compare April 26, 2024 21:56
@redrac redrac force-pushed the feature/add_ssh_key_type_control branch from 09bd694 to 58b33f2 Compare May 8, 2024 20:22
Add --kty, --curve, and --size to ssh commands (login, certificate)

Implements PR smallstep#477
@redrac redrac force-pushed the feature/add_ssh_key_type_control branch from 58b33f2 to 2e9ddd0 Compare May 11, 2024 17:37
@redrac
Copy link
Contributor Author

redrac commented May 11, 2024

@maraino just bumping this one--we are just re-using existing logic so this one seems pretty straightforward

Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @redrac, lgtm

@maraino maraino merged commit aeee3d0 into smallstep:master May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants