-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump geth to v1.13.14, refactoring tests to use newer simulated geth interface #13152
Closed
reductionista
wants to merge
10
commits into
develop
from
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
Closed
bump geth to v1.13.14, refactoring tests to use newer simulated geth interface #13152
reductionista
wants to merge
10
commits into
develop
from
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reductionista
force-pushed
the
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
branch
from
May 9, 2024 00:38
469aec2
to
b88402a
Compare
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
reductionista
force-pushed
the
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
branch
from
May 13, 2024 01:45
386bd91
to
074674e
Compare
reductionista
force-pushed
the
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
branch
from
May 13, 2024 02:08
074674e
to
360b0bc
Compare
reductionista
force-pushed
the
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
branch
from
May 14, 2024 15:25
360b0bc
to
3d1cd25
Compare
reductionista
changed the title
bump geth v1.13.14; rm hack; fix simulated backend; run make generate
bump geth to v1.13.14, refactoring tests to use newer simulated geth interface
May 14, 2024
…lient ( instead of deprecated backends.SimulatedBackendClient )
This test relied on markBlockFinalized() which has been replaced with finalizedBlocksThrough(). Just needed some slight adjustments to keep testing the same thing.
reductionista
force-pushed
the
BCF-3134-refactor-backup-logpoller-test-for-geth-bump
branch
from
May 14, 2024 15:40
3d1cd25
to
57c0f73
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge... just testing some things in CI for now