Upgrade to 16.8 and remove use-hooks #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍻 it looks like there's a few failing tests atm |
|
@NavyAdmiral I messed around with the PR locally and it seems like the problem is that It looks like we may need to wait for enzyme support enzymejs/enzyme#2011 |
|
Ive read about it too and it useLayoutEffect was mentioned as a workaround. Simple replacement didnt work and I didnt get to try anything else out yet |
|
Support for this will be added to enzyme soon. Until then, there is no purpose to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rupurt this is in response to #978
types were set to 16.8 and lockfile was 16.7; use-hooks is no longer needed either