chore: Bump controller-runtime to v0.13.0 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 34.11% 34.11%
=======================================
Files 6 6
Lines 1952 1952
=======================================
Hits 666 666
Misses 1182 1182
Partials 104 104 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fengye87
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update controller-runtime to v0.13.0 to include patch kubernetes-sigs/controller-runtime#1907, otherwise all logger produced by controller-runtime will have the same
controller,controllerGroupandcontrollerKind. E.g the logger comes from functionctrl.LoggerFrom(ctx)will have the valuecontroller: virtualmachinemigration,controllerGroup: virt.virtink.smartx.comandcontrollerKind: VirtualMachineMigrationfor all controllers invirt-controller.