Migrate to streamx #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@perrin4869 can you have a look at this again please? The |
|
That's right, |
|
Thank you for the follow up! |
|
|
|
@perrin4869 done. Thanks for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation behind this PR is that
readable-streamis difficult for bundlers to handle due to circular dependencies (see nodejs/readable-stream#348). I believe this might be the cause behind the discussion here: i18next/i18next-gettext-converter#105Other than that,
streamxseems to have a smaller footprint and other projects like gulp plan to migrate to streamx as well.For your consideration :)
Thanks!