Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Failing Workflow #133

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Debug Failing Workflow #133

merged 4 commits into from
Jun 29, 2023

Conversation

jumaallan
Copy link
Member

@jumaallan jumaallan commented Jun 29, 2023

Story: N/A

Summary

After the 2.5.0 release, workflows with commas in their name fail with the error:

ValidationError: Key Validation Error: v8-gradle|Linux|Build, test and deploy-build-and-test-code[37a6259cc0c1dae299a7866489dff0bd]-7e6e283daa6662e3fbcaffbf38abebc2169ab560 cannot contain commas.

This stems from this issue

Ideally, the cache should not impose additional restrictions on the Workflow name. Vansh left an issue open here

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.

@jumaallan jumaallan requested a review from a team as a code owner June 29, 2023 10:44
@vanshg vanshg merged commit 1460b90 into main Jun 29, 2023
3 checks passed
@vanshg vanshg deleted the buf/debug-workflow branch June 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants