Stream improvement serde #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
requested review from
adamthom-amzn,
gosar,
JordonPhillips and
a team
as code owners
This was referenced Sep 23, 2022
trivikr
reviewed
Sep 26, 2022
.../java/software/amazon/smithy/typescript/codegen/integration/AddSdkStreamMixinDependency.java
Outdated
Show resolved
Hide resolved
trivikr
approved these changes
Sep 26, 2022
srchase
approved these changes
Oct 11, 2022
.../java/software/amazon/smithy/typescript/codegen/integration/AddSdkStreamMixinDependency.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
kuhe
force-pushed
the
stream-improvement-serde
branch
from
06d2b4b
to
0fdf3ca
Compare
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
* generate util functions to consume response stream * inject sdk stream utility function to the stream response * add SDKStreamSerdeContext interface * add internal trait to the sdkStreamMixin config * add missing new line for default modes config * revert SdkStream type in SymbolVisitor, add to command generator * only mixin stream utils in client SDK * feat(serde): use type-mapping to apply stream mixin instead of omit * feat(serde): use ternary Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> * Update AddSdkStreamMixinDependency.java Co-authored-by: AllanZhengYP <zheallan@amazon.com> Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-3375
taking over #571
v3 counterpart: aws/aws-sdk-js-v3#3977