Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(endpoint): deduplicate client context and built-in params with the same name #616

Merged
merged 1 commit into from Oct 18, 2022
Merged

fix(endpoint): deduplicate client context and built-in params with the same name #616

merged 1 commit into from Oct 18, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 18, 2022

  • fix: dedupe clientContextParams with builtInParams with the same name
  • fix for JS conventions: default local param name to camelCase if it is TitleCase

@kuhe kuhe requested a review from a team as a code owner October 18, 2022 16:32
@kuhe kuhe mentioned this pull request Oct 18, 2022
Merged
@kuhe
Copy link
Contributor Author

kuhe commented Oct 18, 2022

aws/aws-sdk-js-v3#4051

@kuhe kuhe merged commit fc5635b into smithy-lang:main Oct 18, 2022
@kuhe kuhe deleted the fix/endpoints-2.0 branch October 18, 2022 19:27
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@kuhe @srchase
fix(endpoint): deduplicate client context and built-in params with th…
5441cb7 
…e same name (smithy-lang#616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuhe @trivikr