Fix dynamax using Pokemon-specific animations #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the term "customAnimation" was overloaded meaning dynamax or a number of other form changes within animTransform. I've added a "isDynamax" flag to force dynamax animation. I figure this is worth the flag since every pokemon can dynamax. The bug report https://github.com/smogon/pokemon-showdown/projects/3#card-85878145 notes that it happens on zygard but it actually would occur on any pokemon with a custom animation.
alphazeba
commented
Jan 23, 2024
Zarel
reviewed
Jan 24, 2024
remove log statement Co-authored-by: Guangcong Luo <guangcongluo@gmail.com>
|
remerged from smogon:master, which should fix the linter issue. Please tell me if there are style guides to the git management on this repo. I would normally rebase and squash the commits, but i'm not used to modifying remote contents. |
KrisXV
changed the title
KrisXV
reviewed
Feb 26, 2024
|
@Zarel sorry, it looks like I had tagged you as a reviewer and I don't think I can remove you. Would you mind peeking this again? |
|
@KrisXV feel free to merge without my review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the term "customAnimation" was overloaded meaning dynamax or a number of other form changes within animTransform. I've added a "isDynamax" flag to force dynamax animation. I figure this is worth the flag since every pokemon can dynamax.
The bug report https://github.com/smogon/pokemon-showdown/projects/3#card-85878145 notes that it happens on zygard but it actually would occur on any pokemon with a custom animation.
examples:
before
after: