Fix to Best-Of checkbox #2218
Open
Fix to Best-Of checkbox #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisXV
reviewed
Jan 27, 2024
| @@ -949,7 +949,7 @@ | |||
| if (bestOf && bestOfValue) { | |||
| var hasCustomRules = format.includes('@@@'); | |||
| format += hasCustomRules ? ', ' : '@@@'; | |||
| format += 'Best of = ' + bestOfValue; | |||
| format += '!!Best of = ' + bestOfValue; | |||
There was a problem hiding this comment.
Should there be logic here to only add !! if the best of rule already exists?
There was a problem hiding this comment.
Should there be logic here to only add
!!if the best of rule already exists?
I don't see why it would make a difference personally.
There was a problem hiding this comment.
I didn't know that was a thing, my bad.
There was a problem hiding this comment.
I did try to make it conditional but I couldn't really figure out how to make sure it would cover all possible syntaxes for the best-of command, then I thought it wouldn't be needed so I let if be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best-of-X checkbox when challenging someone does not work if the format is already set to Bo3 or Bo5. You get this error if you try to use it:
- Rule "bestof=5" conflicts with "bestof=3" (Use "!! bestof=5" to override "bestof=3".)This fix solves this issue by making sure the best-of command always overrides any pre-existing best-of commands.