Mafia: Refactor plugin to stop misusing the playerTable #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of a larger refactor of the plugin.
Unbeknownst to me when I wrote this plugin, playerTable is not a source of truth for who is in the game or not. With this commit, I'm making it a policy for the mafia plugin to never directly read or mutate from the playerTable. As an alternative, RoomGame#players is an array of players that can be accessed, and a Mafia#getPlayer(ID) method was added for ease of getting a specific player.
…nt from remaining players. Some playerTable references were missed and removed in this commit. RoomGame#playerCount will no longer reflect the number of un-eliminated players as players in a Mafia game can be revived and are not removed from the game until it ends or they sub out. Instead, we will not use the Mafia#getRemainingPlayers() method to get a array of remaining players and check its length for the uneliminated player count.
HoeenCoder
force-pushed
the
mafia-refactor
branch
2 times, most recently
from
e61724c
to
a6084c9
Compare
HoeenCoder
force-pushed
the
mafia-refactor
branch
from
a6084c9
to
3c857a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a large refactor with several commits, I'm PRing this in draft form to allow reviews as I complete portions of the refactor.
The overall goal is to stop directly accessing, iterating over, and modifying the playerTable from RoomGame which is causing all sorts of issues for mafia players.
Expect this to take a while to complete.