Emergency Exit now activates between hazards

[chouettevan]

Fixed an emergency exit bug.it should now activate between hazards.

[MathyFurret]

Hi and welcome to the PS repository! From my testing, Emergency Exit already works fine with hazards; here is a replay from the current version of the main server: https://replay.pokemonshowdown.com/gen7anythinggoes-2127259105

Can you provide a replay that demonstrates the bug?

[chouettevan]

The problem is not that emergency exit does not activate after entry hazards but that it does not activate between hazards
Here is a replay from the current version of the main server:https://replay.pokemonshowdown.com/gen7ou-2128354558-sf422zzrt4pfpufmk9mi5bklotct5gipw

[MathyFurret]

I see, thanks! Unfortunately, I don't think this will fix the issue. The EntryHazard is used for triggering entry hazards, not running effects related to them. What your change would do is make the Emergency Exit ability's handler run at the same time as the entry hazards will. Due to the order event handlers are queued in, the ability's handler always runs before the hazards themselves, instead of between them, which is what we need.

Also, you should generally include a unit test for mechanics fixes. Conveniently there already is one on line 324 of test/sim/abilities/emergencyexit.js; all you have to do is delete the .skip.