Fix logs for protosynthesis and quarkdrive #10300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 14, 2024 10:27
…ssary string slicing on client end to get stat name
Zarel
reviewed
May 16, 2024
data/abilities.ts
Outdated
Comment on lines
4610
to
4615
| let activated = false; | ||
| for (const target of pokemon.adjacentFoes()) { | ||
| if (!activated) { | ||
| this.add('-ability', pokemon, 'Supersweet Syrup', 'boost'); | ||
| activated = true; | ||
| } |
There was a problem hiding this comment.
This does not appear to be a documented change.
There was a problem hiding this comment.
This was already merged here: #10296 (comment)
There was a problem hiding this comment.
Sounds like it needs to be rebased/merged, then? I can do that for you if that's difficult.
There was a problem hiding this comment.
Oh sure thing! thankyou!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect logs with stat name appended to the effect (for example
protosynthesisdef) requiring an explicit if-else check and string slicing for protosynthesis and quarkdrive on the client side.This needs my PR smogon/pokemon-showdown-client#2248 on the client side to be merged at the same time in order for everything to work.