Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #68

Merged
merged 2 commits into from Feb 8, 2023
Merged

Upgrade deps #68

merged 2 commits into from Feb 8, 2023

Conversation

tnicolaisen-snabble
Copy link
Contributor

Of course the day after I release all the otel things are released :D

@tnicolaisen-snabble tnicolaisen-snabble requested a review from a team February 8, 2023 13:44
@tnicolaisen-snabble
Copy link
Contributor Author

Seeing this again:

--- FAIL: Test_NewGlobalNoopTraceProvider_SetsTheGlobalProvider (0.00s)
panic: cannot merge resource due to conflicting Schema URL [recovered]

open-telemetry/opentelemetry-go#2341 is closed (not sure how it was resolved since the problem still occurs for us). There's a pointer to open-telemetry/opentelemetry-collector-contrib#5036 which is still open.

@J-Rocke
Copy link
Member

J-Rocke commented Feb 8, 2023

Zumindest haben wir jetzt eine zentrale Stelle wo wir das lösen können

@tnicolaisen-snabble
Copy link
Contributor Author

We just have to manually upgrade to the corresponding schema each time ✔️

@tnicolaisen-snabble
Copy link
Contributor Author

There's also a schema-less function we could use that would probably avoid this hassle, but then we won't get reminded to upgrade the schema. That could lead to issues way down the road, when tooling expects us to follow a certain schema, I suppose.

@tnicolaisen-snabble tnicolaisen-snabble merged commit 8a7512a into master Feb 8, 2023
@tnicolaisen-snabble tnicolaisen-snabble deleted the upgrade-deps branch February 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants